-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow configuration panel during upload #390
Open
ferishili
wants to merge
13
commits into
Opencast-Moodle:master
Choose a base branch
from
ferishili:issue-389
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig helper class as well
ferishili
added
enhancement
has behat
The feature contains behat testing scenarios or modified existing ones
feature
has phpunit
The changes also include PHPUnit tests
labels
Oct 1, 2024
IDEAS & FEEDBACK from Community meeting:
|
In my test environment, based on the lms-community-integration from @mtneug, calling up the processing settings in the single and in the batch upload page worked so far. However, as I did not add any further workflows in Opencast, I could not test several possibilities to upload process to the end. |
bluetom
requested review from
bluetom
and removed request for
justusdieckmann
November 22, 2024 08:31
In my test environment the PR works as expected. |
bluetom
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.5.1
enhancement
feature
has behat
The feature contains behat testing scenarios or modified existing ones
has phpunit
The changes also include PHPUnit tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #389,
Requirements:
It is very important for this PR to work properly, specially with passing wf configs to ingest api, to use this PR from
tool_opencast
plugin Upgrade Opencast PHP Library to 1.8.0 + Api Version setting (OC 16 Support) + Moodle 4.4 Required Changes moodle-tool_opencast#63For this to work, opencast admin must make sure that the upload workflow is properly set and it has configuration panel elements!
Description
This PR is the feature request, by which teachers would have the ability to decide further upload process options provided in workflow configuration panel and set and pass them to the upload process.
In simple words, this PR provides the upload workflow configuration panels on the upload page to get user defined values, then pass those values to the workflow to process the uploaded video accordingly.
Settings
There are 2 new settings options added:
Show workflow configurations during upload
(enableuploadwfconfigpanel
) : This is the feature activation setting, by which admins could enable/disable this feature!Allowed upload workflow configurations
(alloweduploadwfconfigs
) : With this setting, admins could set which config panel elements are allowed to be shown in the upload page, it is a comma-separated list of element ids.Leaving it empty means all elements would be shown!
Upload Page:
When all above mentioned requirements and settings are correctly set and configured, there will be a new section right after Event Visibility called Processing Settings in the upload page.
In this sections, every (allowed) element that is provided in the workflow config panel will be converted to moodle form element and shown to the teachers.
IMPORTANT TO KNOW (Standards):
Technical
This PR adds two new columns into
block_opencast_uploadjob
table:workflowconfiguration
: This field contains the user defined (dynamic) workflow configuration values as JSON string.workflowid
: This field contains the initial upload workflow id (retrievable only with ingest)Because of this two new addition this PR requires a plugin version increase, please be advised while testing this PR!
Testing:
To test this PR you would need:
schedule-and-upload
" workflow or an upload workflow that has config panel: the default workflow is shipped withstraightToPublishing
config panel element.Workflow to start after upload
(uploadworkflow
) setting option is configured accordingly.Show workflow configurations during upload
(enableuploadwfconfigpanel
)Allowed upload workflow configurations
(alloweduploadwfconfigs
)NOTE:
this PR is using
oc-16-support
branch from tool_opencast plugin in its moodle-ci file, which is the exact copy of this PR: Opencast-Moodle/moodle-tool_opencast#63When that PR is merged and a new version is out the
branch-tool-plugin: oc-16-support
has to be set back to master!