fix(protocol-designer): blowout field checkbox properly populating (#…

…17093)

closes RQA-3792

This was a weird bug only affecting the UI and not any commands being
generated. Basically, the blowout checkbox was incorrectly not being
selected because there was logic in place to hardcode it
to false due to the disposal volume checkbox being true. IDK why the
disposal volume checkbox is true -- seems like something we allowed for
all move liquid steps back in the day. So for a UI fix, I added the
field to be dependent on the disposal volume fields and removed the
useEffect in place.

protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/index.tsx

@@ -1,4 +1,3 @@
-import { useEffect } from 'react'
 import { useSelector } from 'react-redux'
 import { useTranslation } from 'react-i18next'
 import {
@@ -134,13 +133,6 @@ export function MoveLiquidTools(props: StepFormProps): JSX.Element {
 
   const mappedErrorsToField = getFormErrorsMappedToField(visibleFormErrors)
 
-  // auto-collapse blowout field if disposal volume is checked
-  useEffect(() => {
-    if (formData.disposalVolume_checkbox) {
-      propsForFields.blowout_checkbox.updateValue(false)
-    }
-  }, [formData.disposalVolume_checkbox])
-
   return toolboxStep === 0 ? (
     <Flex
       flexDirection={DIRECTION_COLUMN}

protocol-designer/src/steplist/formLevel/handleFormChange/dependentFieldsUpdateMoveLiquid.ts

@@ -428,6 +428,7 @@ const updatePatchDisposalVolumeFields = (
       ...patch,
       disposalVolume_checkbox: true,
       disposalVolume_volume: recommendedMinimumDisposalVol,
+      blowout_checkbox: false,
     }
   }
 

protocol-designer/src/steplist/formLevel/handleFormChange/test/moveLiquid.test.ts

@@ -313,6 +313,7 @@ describe('disposal volume should update...', () => {
         dispense_mix_checkbox: false,
         dispense_mix_times: null,
         dispense_mix_volume: null,
+        blowout_checkbox: false,
       })
     })