Skip to content

Commit

Permalink
fix(protocol-designer): fix copy for pristine well warning (#16979)
Browse files Browse the repository at this point in the history
Remove starting deck state link from pristine well warning. Also, remove
grid gap between timeline warning title and body.

Closes RQA-3710
  • Loading branch information
ncdiehl11 authored Nov 25, 2024
1 parent 849ad0e commit 2dc3e1d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
3 changes: 1 addition & 2 deletions protocol-designer/src/organisms/Alerts/FormAlerts.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function FormAlertsComponent(props: FormAlertsProps): JSX.Element | null {
width="100%"
iconMarginLeft={SPACING.spacing4}
>
<Flex flexDirection={DIRECTION_COLUMN} gridGap={SPACING.spacing4}>
<Flex flexDirection={DIRECTION_COLUMN}>
<StyledText desktopStyle="bodyDefaultSemiBold">
{data.title}
</StyledText>
Expand Down Expand Up @@ -183,7 +183,6 @@ function FormAlertsComponent(props: FormAlertsProps): JSX.Element | null {
return [...formErrors, ...timelineWarnings, ...formWarnings].length > 0 ? (
<Flex
flexDirection={DIRECTION_COLUMN}
gridGap={SPACING.spacing4}
padding={`${SPACING.spacing16} ${SPACING.spacing16} 0`}
>
{showFormErrors
Expand Down
3 changes: 0 additions & 3 deletions protocol-designer/src/organisms/Alerts/WarningContents.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import { useTranslation } from 'react-i18next'
import { START_TERMINAL_ITEM_ID } from '../../steplist'
import { TerminalItemLink } from './TerminalItemLink'

import type { AlertLevel } from './types'

Expand All @@ -22,7 +20,6 @@ export function WarningContents(
{t(`timeline.warning.${warningType}.body`, {
defaultValue: '',
})}
<TerminalItemLink terminalId={START_TERMINAL_ITEM_ID} />
</>
)
default:
Expand Down

0 comments on commit 2dc3e1d

Please sign in to comment.