address feedback

Opentrons · Dec 18, 2024 · 3671140 · 3671140
1 parent ad6b69e
commit 3671140
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/AddStepButton.tsx b/protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/AddStepButton.tsx
@@ -8,6 +8,7 @@ import {
   BORDERS,
   COLORS,
   DIRECTION_COLUMN,
+  DISPLAY_FLEX,
   Flex,
   Icon,
   JUSTIFY_CENTER,
@@ -133,7 +134,7 @@ export function AddStepButton({ hasText }: AddStepButtonProps): JSX.Element {
         </Tooltip>
       )}
       <SecondaryButton
-        display="flex"
+        display={DISPLAY_FLEX}
         justifyContent={JUSTIFY_CENTER}
         alignItems={ALIGN_CENTER}
         gridGap={SPACING.spacing10}

diff --git a/protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/StepContainer.tsx b/protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/StepContainer.tsx
@@ -49,7 +49,8 @@ import type { BaseState } from '../../../../types'
 const STARTING_DECK_STATE = 'Starting deck'
 const FINAL_DECK_STATE = 'Ending deck'
 const PX_HEIGHT_TO_TOP_OF_CONTAINER = 32
-const SIDEBAR_MIN_WIDTH_FOR_ICON = 179
+const PX_SIDEBAR_MIN_WIDTH_FOR_ICON = 179
+
 export interface StepContainerProps {
   title: string
   iconName: IconName
@@ -95,7 +96,7 @@ export function StepContainer(props: StepContainerProps): JSX.Element {
   const dispatch = useDispatch<ThunkDispatch<BaseState, any, any>>()
   const multiSelectItemIds = useSelector(getMultiSelectItemIds)
 
-  const hasText = sidebarWidth > SIDEBAR_MIN_WIDTH_FOR_ICON
+  const hasText = sidebarWidth > PX_SIDEBAR_MIN_WIDTH_FOR_ICON
   let backgroundColor = isStartingOrEndingState ? COLORS.blue20 : COLORS.grey20
   let color = COLORS.black90
   if (selected) {

diff --git a/protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/TerminalItemStep.tsx b/protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/TerminalItemStep.tsx
@@ -1,5 +1,7 @@
+import { useTranslation } from 'react-i18next'
 import { useSelector, useDispatch } from 'react-redux'
 import { useConditionalConfirm } from '@opentrons/components'
+
 import {
   getHoveredTerminalItemId,
   getSelectedTerminalItemId,
@@ -10,6 +12,7 @@ import {
   getCurrentFormIsPresaved,
   getCurrentFormHasUnsavedChanges,
 } from '../../../../step-forms/selectors'
+import { START_TERMINAL_ITEM_ID } from '../../../../steplist'
 import {
   CLOSE_STEP_FORM_WITH_CHANGES,
   CLOSE_UNSAVED_STEP_FORM,
@@ -21,19 +24,16 @@ import {
   toggleViewSubstep,
 } from '../../../../ui/steps/actions/actions'
 import { StepContainer } from './StepContainer'
-import { START_TERMINAL_ITEM_ID } from '../../../../steplist'
 
 import type {
   SelectTerminalItemAction,
   HoverOnTerminalItemAction,
 } from '../../../../ui/steps'
 import type { TerminalItemId } from '../../../../steplist'
 import type { ThunkDispatch } from '../../../../types'
-import { useTranslation } from 'react-i18next'
 
 export interface TerminalItemStepProps {
   id: TerminalItemId
-  title: string
   sidebarWidth: number
 }
 

diff --git a/protocol-designer/src/pages/Designer/ProtocolSteps/index.tsx b/protocol-designer/src/pages/Designer/ProtocolSteps/index.tsx
@@ -78,7 +78,6 @@ export function ProtocolSteps(): JSX.Element {
     hasTimelineErrors && tab === 'protocolSteps' && formData == null
   const stepDetails = currentStep?.stepDetails ?? null
 
-  console.log('targetWidth', targetWidth)
   return (
     <Flex
       backgroundColor={COLORS.grey10}