fix(protocol-designer): change initial value from null to true

change initial value from null to true close RQA-3797
Opentrons · Dec 18, 2024 · f5e79f4 · f5e79f4
1 parent 4bb6a9c
commit f5e79f4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/protocol-designer/src/analytics/reducers.ts b/protocol-designer/src/analytics/reducers.ts
@@ -5,11 +5,11 @@ import type { Action } from '../types'
 import type { SetOptIn } from './actions'
 import type { RehydratePersistedAction } from '../persist'
 export interface OptInState {
-  hasOptedIn: boolean | null
+  hasOptedIn: boolean
   appVersion?: string
 }
 const optInInitialState = {
-  hasOptedIn: null,
+  hasOptedIn: true,
 }
 
 // @ts-expect-error(sb, 2021-6-17): cannot use string literals as action type

diff --git a/protocol-designer/src/pages/Settings/index.tsx b/protocol-designer/src/pages/Settings/index.tsx
@@ -42,7 +42,7 @@ export function Settings(): JSX.Element {
   const [showAnnouncementModal, setShowAnnouncementModal] = useState<boolean>(
     false
   )
-  const analytics = useSelector(analyticsSelectors.getHasOptedIn)
+  const { hasOptedIn } = useSelector(analyticsSelectors.getHasOptedIn)
   const flags = useSelector(getFeatureFlagData)
   const canClearHintDismissals = useSelector(
     tutorialSelectors.getCanClearHintDismissals
@@ -274,23 +274,21 @@ export function Settings(): JSX.Element {
                   data-testid="analyticsToggle"
                   size="2rem"
                   css={
-                    Boolean(analytics.hasOptedIn)
+                    Boolean(hasOptedIn)
                       ? TOGGLE_ENABLED_STYLES
                       : TOGGLE_DISABLED_STYLES
                   }
                   onClick={() =>
                     dispatch(
-                      analytics.hasOptedIn
+                      hasOptedIn
                         ? analyticsActions.optOut()
                         : analyticsActions.optIn()
                     )
                   }
                 >
                   <Icon
                     name={
-                      analytics.hasOptedIn
-                        ? 'ot-toggle-input-on'
-                        : 'ot-toggle-input-off'
+                      hasOptedIn ? 'ot-toggle-input-on' : 'ot-toggle-input-off'
                     }
                     height="1rem"
                   />

diff --git a/protocol-designer/src/persist.ts b/protocol-designer/src/persist.ts
@@ -9,7 +9,7 @@ export interface RehydratePersistedAction {
     'tutorial.dismissedHints'?: Record<string, any>
     'featureFlags.flags'?: Record<string, any>
     'analytics.hasOptedIn'?: {
-      hasOptedIn: boolean | null
+      hasOptedIn: boolean
       appVersion?: string
     }
   }