refactor: Rename Pydantic v1 methods to their v2 counterparts #17123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
added
the
DO NOT MERGE
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes EXEC-1063.
This is based atop PR #14871. It should merge into
edgeshortly after that PR.Test Plan and Hands on Testing
Just CI.
Changelog
Do a bunch of global find+replaces to rename Pydantic methods according to their migration guide.
In every project that runs on a robot, try to configure pytest to fail a test if it detects that it raised a Pydantic deprecation warning.
This appears to only work for some warnings, but it works for the warnings that I care about and understand, so I didn't look into it further.
Review requests
None in particular.
Risk assessment
Low.