Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol-designer): refine logic for persisted state #17142

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix(protocol-designer): refine logic for persisted state #17142

merged 2 commits into from
Dec 18, 2024
+6 −2

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Dec 18, 2024 •
edited
Loading

Overview

check if optin is null or hasOptedIn is undefined

Test Plan and Hands on Testing

test the sandbox on clear local storage or if your optin setting is set to null

Changelog

refine logic for when persisted state persists

Risk assessment

med

@jerader jerader requested a review from a team as a code owner December 18, 2024 20:02
@jerader jerader requested a review from koji December 18, 2024 20:02
koji
koji approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jerader jerader merged commit aa57afc into chore_release-pd-8.2.2 Dec 18, 2024
14 checks passed
@jerader jerader deleted the pd_persisted-state branch December 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerader @koji