Chore: PD 8.2.2 mergeback into edge #17143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modal (#17121) * fix(protocol-designer) remove hardcoded pd version from release notes modal
#17124) …field The `heaterShakerSetTimer` field's type is `heaterShakerSetTimer: 'true' | 'false' | null` - this was written 3 years ago. However, despite this, the field when checking the checkbox in the form in PD would populate it as `true` or `false` booleans rather than the true/false strings. 2 weeks ago, right before 8.2.0 was released, there was a bug checking the timer checkbox for the temperature module and it was because of this boolean vs boolean strings issue. So I extended it onto the heater-shaker set timer field as well because of its type. Unfortunately, that resulted in this current error: - protocols created in 8.2.0 and 8.2.1 have the `heaterShakerSetTimer` field set to either `'true'` or `'false'` strings - protocols created prior to 8.2.0 have the `heaterShakerSetTimer` field set to `true` or `false` boolean - my initial fix was to update the form field to check for `true` or `false` boolean but that didn't fix any protocols created in 8.2.0 and 8.2.1. - the extended fix unfortunately required a migration so now if `'true'` or `'false'` strings are used in the field, they get migrated to `true` or `false` boolean -- this i believe is the only way to fix all protocol versions
* fix(protocol-designer): change initial value from null to true
jerader
requested review from
ncdiehl11 and
koji
and removed request for
a team
ncdiehl11
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a merge back of PD 8.2.2 release branch into edge