feat(protocol-designer): prevent user from adding plate reader without gripper #17152
+57
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t gripper Here, I prevent saving adding a plate reader in DeckSetupTools if a gripper has not already been added. In a followup, we will enforce a timeline error at for plate reader stepforms that modify the lid state of the reader. Closes AUTH-1095
jerader
reviewed
Dec 19, 2024
protocol-designer/src/pages/Designer/DeckSetup/DeckSetupTools.tsx
Outdated
Show resolved
Hide resolved
jerader
reviewed
Dec 19, 2024
protocol-designer/src/pages/Designer/DeckSetup/DeckSetupTools.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Here, I prevent saving adding a plate reader in DeckSetupTools if a gripper has not already been added. In a followup, we will enforce a timeline error at for plate reader stepforms that modify the lid state of the reader.
TODO: update snackbar copy/confirm that behavior with Design
Closes AUTH-1195
Test Plan and Hands on Testing
Screen.Recording.2024-12-19.at.1.41.01.PM.mov
Changelog
handleConfirminDeckSetupToolsto check for presence of a gripper when saving absorbance readerReview requests
Risk assessment
low