Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E transfer and command update #17156

Open
wants to merge 21 commits into
base: edge
Choose a base branch
from
+236 −353
Open

E2E transfer and command update #17156

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d83c729
I made a robotSelection() function added to commands.ts. Next commit …
alexjoel42 Dec 13, 2024
6b7eff3
you can now select pipettes
alexjoel42 Dec 16, 2024
6e40698
Merge branch 'edge' into E2E_Transfer_and_Command_update
alexjoel42 Dec 16, 2024
df1942d
I moved the base url to be the sandbox instead of local host. This wa…
alexjoel42 Dec 16, 2024
5e9e55d
updated url to 8.2.2 so we can plan for the confirmation modal
alexjoel42 Dec 16, 2024
2950726
refactoring for 8.2.0
alexjoel42 Dec 16, 2024
f156954
very small change to make JS checker happier
alexjoel42 Dec 16, 2024
f40e60e
fixed the protocols using our little pop up.
alexjoel42 Dec 17, 2024
50c6836
just added some functions to get us closer to transfer step 5 woo
alexjoel42 Dec 17, 2024
6300eaa
move baseurl and made deck selector
alexjoel42 Dec 18, 2024
2ccb2de
local host not updated yet
alexjoel42 Dec 18, 2024
13e762c
I changed chose deck slot to just return the deck slot. ToDo is to ma…
alexjoel42 Dec 19, 2024
391d04c
done
alexjoel42 Dec 19, 2024
5b7e02e
Merge branch 'edge' into E2E_Transfer_and_Command_update
alexjoel42 Dec 19, 2024
8750068
we did it! It's prettier
alexjoel42 Dec 19, 2024
8259eec
refactored and linted all tests
alexjoel42 Dec 19, 2024
ae5b69c
Merge branch 'edge' into E2E_Transfer_and_Command_update
alexjoel42 Dec 19, 2024
29903d3
formatting fixed in a few places with prettier
alexjoel42 Dec 19, 2024
f402fa5
hope this updates
alexjoel42 Dec 19, 2024
0a5c1c6
another commit to finally fix the deck slot function
alexjoel42 Dec 19, 2024
d7fb3d2
small steps
alexjoel42 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocol-designer/cypress/e2e/createNew.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ import { UniversalActions } from '../support/universalActions'
describe('The Redesigned Create Protocol Landing Page', () => {
beforeEach(() => {
cy.visit('/')
cy.contains('button', 'Confirm').click()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to a new command in protocol-designer/cypress/support/commands.ts and give it a meaningful name.

})

it('content and step 1 flow works', () => {
cy.closeAnalyticsModal()
cy.clickCreateNew()
cy.verifyCreateNewHeader()
verifyCreateProtocolPage()
Expand Down
3 changes: 2 additions & 1 deletion protocol-designer/cypress/e2e/import.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,18 @@ import {
describe('The Import Page', () => {
beforeEach(() => {
cy.visit('/')
cy.closeAnalyticsModal()
})

it('successfully loads a protocol exported on a previous version', () => {
cy.contains('button', 'Confirm').click()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in the beforeEach using the new command you create.

const protocol = getTestFile(TestFilePath.DoItAllV7)
cy.importProtocol(protocol.path)
verifyOldProtocolModal()
verifyImportProtocolPage(protocol)
})

it('successfully loads a protocol exported on the current version', () => {
cy.contains('button', 'Confirm').click()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

const protocol = getTestFile(TestFilePath.DoItAllV8)
cy.importProtocol(protocol.path)
verifyImportProtocolPage(protocol)
Expand Down
3 changes: 2 additions & 1 deletion protocol-designer/cypress/e2e/migrations.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import { TestFilePath } from '../support/testFiles'
describe('Protocol fixtures migrate and match snapshots', () => {
beforeEach(() => {
cy.visit('/')
cy.closeAnalyticsModal()
// Get rid of the analytics
cy.contains('button', 'Confirm').click()
})

const testCases: MigrateTestCase[] = [
Expand Down
2 changes: 1 addition & 1 deletion protocol-designer/cypress/e2e/settings.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('The Settings Page', () => {
before(() => {
cy.visit('/')
cy.closeAnalyticsModal()
cy.contains('button', 'Confirm').click()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the command.

})

it('content and toggle state', () => {
Expand Down
Loading
Loading