fix(protocol-designer): properly delete and generate adapter/labware … #17157
Conversation
…combo when editing closes RQA-3777
|
Not sure if this is the same bug? |
@ncdiehl11 - oof nice catch. i think thats a new bug. i'll try to fix it in this PR |
@ncdiehl11 ok the bug you found is because the moduleId in the steps doesn't match the moduleId in module entities, and that is because when you edited your heater-shaker labware, the heater-shaker module gets regenerated, meaning it has a new moduleId. I guess the correct fix here is to update each step to have the correct moduleId if you edit the module. I'll work on fixing that in this PR |
| ) | ||
| const magneticModuleDisplayName = | ||
| getModuleDisplayName(modules[magneticModuleId]?.model) ?? | ||
| 'Unknown module' |
There was a problem hiding this comment.
unknown module is the fallback for each of these. users should not be running into it
There was a problem hiding this comment.
nit maybe add a translation here
|
closing this in lieu of this identical PR targeting PD 8.2.3 for a hot fix: #17161 |
…combo when editing
closes RQA-3777 RQA-3804
Overview
Wowza this was a very annoying bug haha, took me about 4 hours to figure out what to do to handle all cases. basically, we weren't properly regenerating labware if you edit the labware on top of the adapter but not the adapter. this PR fixes that
Test Plan and Hands on Testing
Look at the ticket and test the example, then test editing labware in general on the deck, on an adapter and on a module and make sure it all works as expected
For the 2nd bug fix, upload the attached protocol, edit the labware on top of the heater-shaker module and go back to the protocol steps and see that the heater-shaker steps don't error. The transfer steps error and that's because we no longer have the dispense labware
1.0 testing (18).json
Changelog
refine logic for when to delete and create labware
create thunk for creating module and migrating the saved step forms module id
Risk assessment
low