feat(protocol-designer,-step-generation): add skeleton for plate reader steps #17158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er steps Here I add a skeleton step form for plate reader step addition (hidden behind feature flag). I also add the a new `lidOpen` property to the plate reader's temporal properties interface since we will need to know this state during step generation in order to perform initializations/readings and to move labware to and from the module.
jerader
reviewed
Dec 20, 2024
| @@ -64,6 +64,7 @@ export interface MagneticBlockState { | |||
| } | |||
| export interface AbsorbanceReaderState { | |||
| type: typeof ABSORBANCE_READER_TYPE | |||
| lidOpen: boolean | null | |||
There was a problem hiding this comment.
null means we don't know what the lid state is?
There was a problem hiding this comment.
yes, at the beginning of the protocol, since the lid state is unknown (Schrodingers lid). We follow this paradigm for HS latch and TC lid
jerader
approved these changes
Dec 20, 2024
Good catch, I added a temp translation since designs are not handed over yet for "absorbance reader". We can change later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Here I add a skeleton step form for plate reader step addition (hidden behind feature flag). I also add the a new
lidOpenproperty to the plate reader's temporal properties interface since we will need to know this state during step generation in order to perform initializations/readings and to move labware to and from the module.Closes AUTH-1196
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low