Fix code check

Opetushallitus · Apr 11, 2024 · d2b3bc5 · d2b3bc5
1 parent c24d7f5
commit d2b3bc5
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/.github/actions/code_check/action.yml b/.github/actions/code_check/action.yml
@@ -7,8 +7,15 @@ runs:
     - name: Lint web
       working-directory: ./web
       shell: bash
+      run: npm ci
+      run: npm run lint
+    - name: Lint localizations
+      working-directory: ./scripts
+      shell: bash
+      run: npm ci
       run: npm run lint
     - name: Lint playwright
       working-directory: ./playwright
       shell: bash
+      run: npm ci
       run: npm run lint
diff --git a/.github/workflows/build_test_push.yml b/.github/workflows/build_test_push.yml
@@ -20,8 +20,6 @@ jobs:
         with:
           node-version: v20.11.0
           cache: npm 
-      - name: npm install
-        run: npm ci
       - name: Code check
         uses: ./.github/actions/code_check
   localization_check_untuva:

diff --git a/scripts/package.json b/scripts/package.json
@@ -13,7 +13,7 @@
     "xlsx": "https://cdn.sheetjs.com/xlsx-0.20.1/xlsx-0.20.1.tgz"
   },
   "scripts": {
-    "lint": "tsc && eslint *.ts",
+    "lint": "tsc && eslint *.ts && npm run localizations list-missing untuva",
     "localizations": "node --no-warnings --loader @swc-node/register/esm localizations.ts"
   }
 }
diff --git a/web/package.json b/web/package.json
@@ -7,7 +7,7 @@
     "dev": "vite --host",
     "build": "tsc && vite build",
     "build:ci": "tsc && vite build --mode CI",
-    "lint": "tsc --noEmit && eslint src/**/*.ts src/**/*.tsx && cd ../scripts && npm run localizations list-missing untuva",
+    "lint": "tsc --noEmit && eslint src/**/*.ts src/**/*.tsx",
     "lint:fix": "eslint --fix src/**/*.ts src/**/*.tsx",
     "test": "vitest",
     "test:watch": "vitest watch"