deprecate ownerAlias (#191)

* ownerAlias deprecated for service inputs * pointer * fix mistakes in service.go Co-authored-by: Kyle Rockman <[email protected]> * s/owner_alias/owner --------- Co-authored-by: Kyle Rockman <[email protected]>
OpsLevel · Oct 25, 2023 · a3afe0a · a3afe0a
1 parent a1e504a
commit a3afe0a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/.changes/unreleased/Refactor-20231020-134153.yaml b/.changes/unreleased/Refactor-20231020-134153.yaml
@@ -0,0 +1,3 @@
+kind: Refactor
+body: BREAKING CHANGE ownerAlias deprecated on service inputs
+time: 2023-10-20T13:41:53.279163-04:00
diff --git a/src/cmd/service.go b/src/cmd/service.go
@@ -30,7 +30,8 @@ product: "OSS"
 language: "Go"
 tier: "tier_4"
 framework: "fasthttp"
-owner: "Platform"
+owner:
+  alias: "Platform"
 EOF`,
 	Run: func(cmd *cobra.Command, args []string) {
 		input, err := readServiceCreateInput()
@@ -207,15 +208,15 @@ EOF
 				}
 			}
 			lifecycle := reader.Text("Lifecycle")
-			if tier != "" {
+			if lifecycle != "" {
 				if item, ok := opslevel.Cache.Lifecycles[lifecycle]; ok {
 					input.Lifecycle = item.Alias
 				}
 			}
 			owner := reader.Text("Owner")
-			if tier != "" {
+			if owner != "" {
 				if item, ok := opslevel.Cache.Teams[owner]; ok {
-					input.Owner = item.Alias
+					input.Owner = opslevel.NewIdentifier(item.Alias)
 				}
 			}
 			service, err := getClientGQL().CreateService(input)

diff --git a/src/cmd/terraform.go b/src/cmd/terraform.go
@@ -227,7 +227,7 @@ func flattenTier(value opslevel.Tier) string {
 
 func flattenOwner(value opslevel.TeamId) string {
 	if value.Id != "" {
-		return fmt.Sprintf("owner_alias = opslevel_team.%s.alias", value.Alias)
+		return fmt.Sprintf("owner = opslevel_team.%s.alias", value.Alias)
 	}
 	return ""
 }

diff --git a/src/submodules/opslevel-go b/src/submodules/opslevel-go
+3 −0		.changes/unreleased/Refactor-20231020-134723.yaml
+18 −18		service.go