Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task setup to taskfile #169

Merged
merged 3 commits into from
Sep 15, 2023
Merged

add task setup to taskfile #169

merged 3 commits into from
Sep 15, 2023

Conversation

davidbloss
Copy link
Contributor

Adding task setup to:

  • 📈 increase DevX
  • 👍 wrap up Adopt Taskfiles campaign

@davidbloss davidbloss requested review from rocktavious and a user September 15, 2023 14:29
ghost
ghost approved these changes Sep 15, 2023
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and WOMM!

As an aside do you get this error when running this command? If so, can we push a commit to this branch to fix it before merging? nevermind rofl my go version is just out of date!

@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #169 (d14409b) into main (c9c2b4a) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #169   +/-   ##
=====================================
  Coverage   6.22%   6.22%           
=====================================
  Files          5       5           
  Lines        257     257           
=====================================
  Hits          16      16           
  Misses       241     241
Files Changed Coverage Δ
src/common/client.go 0.00% <ø> (ø)
src/common/prompts.go 0.00% <ø> (ø)

ghost
ghost approved these changes Sep 15, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gofumpt changes lgtm

@davidbloss davidbloss merged commit fc38982 into main Sep 15, 2023
5 checks passed
@davidbloss davidbloss deleted the db/add-setup-task branch September 15, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocktavious rocktavious rocktavious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbloss @rocktavious