Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow "infra" when managing infra tags #186

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

davidbloss
Copy link
Contributor

Issues

Changelog

Add infra as a type when managing tags. Otherwise users would have to type out --type=InfrastructureResource

opslevel list tag --type=infra <infra-ID>
  • List your changes here
  • Make a changie entry

Tophatting

opslevel get tag --type=infra Z2lkOi8vb3BzbGV2ZWwvRW50aXR5T2JqZWN0LzU1OTczOA neat-key-2
[
  {
    "id": "Z2lkOi8vb3BzbGV2ZWwvVGFnLzYxMjYyNDUw",
    "key": "neat-key-2",
    "value": "neat-value-2"
  }
]

opslevel list tag --type=infra Z2lkOi8vb3BzbGV2ZWwvRW50aXR5T2JqZWN0LzU1OTczOA
[
  {
    "id": "Z2lkOi8vb3BzbGV2ZWwvVGFnLzYxMjYyNDUw",
    "key": "neat-key-2",
    "value": "neat-value-2"
  }
]

@davidbloss davidbloss requested review from rocktavious and a user October 4, 2023 19:31
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #186 (ef9b792) into main (a3ee612) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #186   +/-   ##
=====================================
  Coverage   6.22%   6.22%           
=====================================
  Files          5       5           
  Lines        257     257           
=====================================
  Hits          16      16           
  Misses       241     241           

Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@davidbloss davidbloss merged commit f3fbfab into main Oct 5, 2023
5 checks passed
@davidbloss davidbloss deleted the db/add-user-and-infra-tags-support branch October 5, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants