Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scorecard example docs to include affectsOverallServiceLevels #192

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Oct 20, 2023

Issues

#71

Changelog

Update scorecard example docs to include AffectsOverallServiceLevels for scorecard create and update.

  • List your changes here
  • Make a changie entry, N/A only updated command docs

Tophatting

opslevel create scorecard -f sc.yaml where sc.yaml looks very close to example in command docs.
Update sc.yaml to switch affectsOverallServiceLevels: false to affectsOverallServiceLevels: true
opslevel update scorecard <scorecard-ID> -f sc.yaml

@davidbloss davidbloss marked this pull request as draft October 20, 2023 20:06
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #192 (3d9f1ab) into main (c05469d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #192   +/-   ##
=====================================
  Coverage   6.22%   6.22%           
=====================================
  Files          5       5           
  Lines        257     257           
=====================================
  Hits          16      16           
  Misses       241     241           

@davidbloss davidbloss requested review from a user and rocktavious October 25, 2023 16:00
@davidbloss davidbloss marked this pull request as ready for review October 25, 2023 16:00
@davidbloss davidbloss merged commit a1e504a into main Oct 25, 2023
5 checks passed
@davidbloss davidbloss deleted the db/add-affectsOverallServiceLevels-field branch October 25, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants