Db/deprecate groups #198
Merged
Db/deprecate groups #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
=====================================
Coverage 6.22% 6.22%
=====================================
Files 5 5
Lines 257 257
=====================================
Hits 16 16
Misses 241 241 |
rocktavious
reviewed
Nov 1, 2023
src/cmd/group.go
Outdated
| Use: "group", | ||
| Aliases: []string{"groups"}, | ||
| Short: "Imports groups from a CSV", | ||
| Deprecated: `Please convert all Groups into Teams. See https://docs.opslevel.com/docs/groups`, |
There was a problem hiding this comment.
Since you removed the create and update functionality - should we also remove the "import" functionality?
There was a problem hiding this comment.
I'm thinking that customers might use this to get a snapshot of their current Groups so that they can know what's left to convert to Teams
There was a problem hiding this comment.
Removing per offline discussion
rocktavious
approved these changes
Nov 1, 2023
ghost
approved these changes
Nov 1, 2023
rocktavious
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#132
Changelog
Deprecate
groupcommands in favor of Team hierarchies.group createandgroup updateare no-ops. The othergroupcommands direct devs to the docs and to use Teams.changieentryTophatting