Export Teams and team memberships to Terraform

[ghost]

Issues

After shipping OpsLevel/terraform-provider-opslevel#144 some customers can be in a state where their terraform Team configs are not using the new member { } blocks. This results in Team Memberships not being able to reconcile without kicking all members out of the terraform managed teams.

Also, the terraform export output is not compatible with the latest TF schema version.

Changelog

• Change export team function
• Minor changes: fix unnecessary line spaces, add line spaces between team resources to make it easier to read
• Make a changie entry

Tophatting

Before:

resource "opslevel_team" "platform" {
  name = "platform"
  manager_email = ""
  aliases = ["platform"]
  
}
resource "opslevel_team" "platform_2" {
  name = "Platform"
  manager_email = ""
  aliases = ["platform_2"]
  
}

After (places a line space between resources):

resource "opslevel_team" "platform" {
  aliases = ["platform"]
  name = "platform"
  member {
    email = "[email protected]"
    role = "contributor"
  }
  member {
    email = "[email protected]"
    role = "contributor"
  }
}

resource "opslevel_team" "platform_2" {
  aliases = ["platform_2"]
  name = "Platform"
  group = "platform"
  member {
    email = "[email protected]"
    role = "contributor"
  }
  parent = ["engineering"]
}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad801cd) 6.37% compared to head (93831d7) 6.37%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #206   +/-   ##
=====================================
  Coverage   6.37%   6.37%           
=====================================
  Files          5       5           
  Lines        251     251           
=====================================
  Hits          16      16           
  Misses       235     235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidbloss]

As of 12 days ago team aliases are required so this len() check should be removed.

[davidbloss]

Can we please introduce strings.Builder here?
We can set teamBody := strings.Builder{} just above this for loop then:

1. sb.WriteString("strings below")
2. sb.String() // to return the whole string to config.WriteString(templateConfig() below
3. sb.Reset() // to reset the underlying buffer at the end of each loop iteration

Running this command is surprisingly slow and this would be a small step in a more optimized direction IMO

[ghost]

Added!

[davidbloss]

This if len() check is safe to remove since appending an empty string doesn't really change teamBody

[davidbloss]

Actually where membersOutput starts down to here seems like a good candidate for a small function. Lmk if you would like to discuss :)
Something loosely like membersOutput := getMembershipsAsTerraformConfig(team.Memberships.Nodes)

[ghost]

Implemented these suggestions

[davidbloss]

Can memberConfig be moved out of the for loop?
Overall this looks good! 👍

[ghost]

Moved!

[davidbloss]

LGTM! 🎉