-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Db/manage property definitions #214
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
========================================
- Coverage 6.37% 6.29% -0.08%
========================================
Files 5 5
Lines 251 254 +3
========================================
Hits 16 16
- Misses 235 238 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple change requests
} | ||
|
||
func getExamplePropertyDefinitionYaml() string { | ||
schema := `{"$schema":"https://json-schema.org/draft/2020-12/schema", "type": "boolean"}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use a more featureful example - can you reachout to foundations and ask what examples/templates they are putting in the UI and put one of the more complex ones here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! The more feature rich example will live in opslevel-go
Issues
Changelog
Add support for PropertyDefinitions
Add
gen
command that generates example yaml based on given structsopslevel gen property-definition
added hereList your changes here
Make a
changie
entryExtra changes actually match up with what's in main. Artifacts of rebasing
Tophatting