grammar fixes, quote vars in bash, fix README links #241
Conversation
taimoorgit
changed the base branch from
main
to
ta/smallfixesremovelingeringtodos
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 6.29% 18.58% +12.29%
==========================================
Files 5 7 +2
Lines 254 312 +58
==========================================
+ Hits 16 58 +42
- Misses 238 250 +12
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. |
taimoorgit
added
go
taimoorgit
force-pushed
the
ta/smallfixesremovelingeringtodos
branch
2 times, most recently
from
4064a3d to
8752e3b
Compare
taimoorgit
force-pushed
the
ta/staticcheck-cli
branch
from
84e68c4 to
26726fb
Compare
| @@ -1,21 +1,23 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -e | |||
There was a problem hiding this comment.
Added so that the CI can just exit if an error is encountered, preventing the script from trying to continue to run.
taimoorgit
changed the title
| DEBIAN_RELEASES=$(debian-distro-info --supported) | ||
| UBUNTU_RELEASES=$(ubuntu-distro-info --supported-esm) | ||
|
|
||
| mkdir -p cli-repo/deb | ||
| cd cli-repo/deb | ||
|
|
||
| for release in ${DEBIAN_RELEASES[@]} ${UBUNTU_RELEASES[@]}; do | ||
| for release in "${DEBIAN_RELEASES[@]}" "${UBUNTU_RELEASES[@]}"; do |
There was a problem hiding this comment.
This raises the question.
What bash/shell linters are we using for this project?
I know that my shell linter config is different than Kyle's config, and our "format on save" features are overwriting each others quote / curly braces defaults. This is a small annoyance that we should reconcile as a team.
There was a problem hiding this comment.
@davidbloss great question - I used GoLand and it pointed out these errors to me.
I am pretty sure that it is using shellcheck under the hood.
Having a CI routine that runs shellcheck on all bash/sh programs would be an excellent thing to add.
We added something like this at my old job that really helped prevent potentially bad code script changes from merging in.
No description provided.