Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent properties changes - add support for Locked, ALLOWED_IN_CONFIG_FILES #258

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

taimoorgit
Copy link
Contributor

@taimoorgit taimoorgit commented Mar 6, 2024

Issues

https://github.com/OpsLevel/team-platform/issues/256

Changelog

  • Update list command output
  • Make a changie entry

Tophatting

List properties on a service

$ go run main.go list -o csv property tsvc
ID,LOCKED,ALIASES
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi85OA,false,is_beta_feature
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi8yODk,false,slug/linters/linters_property
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi8yODA,false,number
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi82OA,false,some_definition
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi82OQ,false,some_definition_clone/some_definition_clooooone

$ go run main.go list property tsvc
ID                                                       LOCKED  VALUE                                              ALIASES
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi85OA   false                                                      is_beta_feature
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi8yODk  false   ["nilaway,","shellcheck","govet","golangci-lint"]  slug,linters,linters_property
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi8yODA  false   99                                                 number
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi82OA   false                                                      some_definition
Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi82OQ   false                                                      some_definition_clone,some_definition_clooooone

List property definitions

$ go run main.go list -o csv pd
ALIASES,ID,NAME,DISPLAY_STATUS,ALLOWED_IN_CONFIG_FILES
is_beta_feature,Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi85OA,Is Beta Feature,visible,true
slug/linters/linters_property,Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi8yODk,linters property,visible,true
number,Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi8yODA,number,visible,true
some_definition,Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi82OA,Some Definition,visible,true
some_definition_clone/some_definition_clooooone,Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi82OQ,Some Definition (Clooooone),visible,true

$ go run main.go list pd
ALIASES                                          ID                                                       NAME                         DISPLAY_STATUS         ALLOWED_IN_CONFIG_FILES
is_beta_feature                                  Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi85OA   Is Beta Feature              visible                true
slug/linters/linters_property                    Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi8yODk  linters property             visible                true
number                                           Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi8yODA  number                       visible                true
some_definition                                  Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi82OA   Some Definition              visible                true
some_definition_clone/some_definition_clooooone  Z2lkOi8vb3BzbGV2ZWwvUHJvcGVydGllczo6RGVmaW5pdGlvbi82OQ   Some Definition (Clooooone)  visible                true

Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@taimoorgit taimoorgit merged commit 6dae23d into main Mar 7, 2024
4 checks passed
@taimoorgit taimoorgit deleted the ta/sp-listing branch March 7, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants