Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opslevel update service command correctly updates fields #305

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Jul 18, 2024

Issues

Regression with update service command

Changelog

Stop updating omitted fields (nil in this case) and only set fields to null if string is an empty string or null

  • List your changes here
  • Make a changie entry

Tophatting

@davidbloss davidbloss added the bug Something isn't working label Jul 18, 2024
@davidbloss davidbloss requested a review from rocktavious July 18, 2024 14:57
@davidbloss davidbloss self-assigned this Jul 18, 2024
@rocktavious
Copy link
Collaborator

I know i had qualms about the null string being a thing. But if this truely fixes something then i'm good with it. I would be cautious about merging this though as it might have intended side effects because in json terms "null" is not the same as null but you are making them equal here

@davidbloss
Copy link
Contributor Author

I know i had qualms about the null string being a thing. But if this truely fixes something then i'm good with it. I would be cautious about merging this though as it might have intended side effects because in json terms "null" is not the same as null but you are making them equal here

I took the "null" part out as it wasn't needed and if customers set something to null in json/yaml it's read in as nil anyway

@davidbloss davidbloss merged commit 1f43b99 into main Jul 25, 2024
4 checks passed
@davidbloss davidbloss deleted the db/fix-update-service-cmd branch July 25, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants