Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify ingress creation #51

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

rocktavious
Copy link
Collaborator

Issues

Add ability to configure and ingress

Changelog

  • List your changes here
  • Make a changie entry

Tophatting

@rocktavious rocktavious self-assigned this Dec 4, 2024
@rocktavious
Copy link
Collaborator Author

@jkrebstadt - My understanding is you'd need something like this possibly?

@jkrebstadt
Copy link
Contributor

@jkrebstadt - My understanding is you'd need something like this possibly?

For us its currently enough to have the ability to add annotation.
So https://github.com/OpsLevel/helm-charts/pull/52/files solves the issue.
However i guess its beneficial to add a standard ingress option to the helm chart.

Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@rocktavious rocktavious merged commit e421b9d into main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants