Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete aliases on infrastructure resources #293

Merged
2 commits merged into from
Nov 7, 2023
Merged

Delete aliases on infrastructure resources #293

2 commits merged into from
Nov 7, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 7, 2023

Issues

https://github.com/OpsLevel/team-platform/issues/112

Changelog

  • Make a changie entry

Tophatting

See terraform provider change: OpsLevel/terraform-provider-opslevel#150

@ghost ghost requested review from rocktavious and davidbloss November 7, 2023 21:50
@ghost ghost self-assigned this Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #293 (dc05621) into main (5d445bd) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   77.22%   77.10%   -0.12%     
==========================================
  Files          50       50              
  Lines        3302     3307       +5     
==========================================
  Hits         2550     2550              
- Misses        549      554       +5     
  Partials      203      203              
Files Coverage Δ
aliases.go 82.14% <0.00%> (-8.06%) ⬇️

Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ghost ghost merged commit 86c3889 into main Nov 7, 2023
5 checks passed
@ghost ghost deleted the delete-infra-aliases branch November 7, 2023 22:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant