Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update submodule hash, make tasks work the same in any dir #190

Merged
merged 7 commits into from
Jan 22, 2024

Conversation

davidbloss
Copy link
Contributor

Issues

Changelog

  • List your changes here
  • Make a changie entry, N/A Taskfile update only

Tophatting

@davidbloss davidbloss requested a review from taimoorgit January 19, 2024 16:40
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (212f2d0) 44.75% compared to head (0cb89e3) 44.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   44.75%   44.75%           
=======================================
  Files          71       71           
  Lines        5865     5865           
=======================================
  Hits         2625     2625           
  Misses       3235     3235           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taimoorgit taimoorgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments - I don't think we should include the terraform formatting related commands. They are too niche and not required for anyone who isn't tophatting. I personally just let my editor format my terraform files.

Taskfile.yml Show resolved Hide resolved
Taskfile.yml Outdated Show resolved Hide resolved
Taskfile.yml Show resolved Hide resolved
Taskfile.yml Show resolved Hide resolved
@davidbloss davidbloss merged commit c724247 into main Jan 22, 2024
6 checks passed
@davidbloss davidbloss deleted the db/fix-clunky-Taskfile-UX branch January 22, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants