Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix updates to owner and description fields, can assign alias not just id #195

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

davidbloss
Copy link
Contributor

…t id

Issues

Changelog

Fix updates to owner and description fields of Property Assignment resources. Before only ids were accepted even if an alias was provided.

  • List your changes here
  • Make a changie entry

Tophatting

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (31b2109) 44.75% compared to head (0ac5842) 44.75%.

❗ Current head 0ac5842 differs from pull request most recent head ddeb7d2. Consider uploading reports for the commit ddeb7d2 to get more accurate results

Files Patch % Lines
opslevel/resource_opslevel_property_assignment.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   44.75%   44.75%           
=======================================
  Files          71       71           
  Lines        5865     5865           
=======================================
  Hits         2625     2625           
  Misses       3235     3235           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some wording changes to the changelog entry

@davidbloss davidbloss merged commit 782f390 into main Jan 24, 2024
4 checks passed
@davidbloss davidbloss deleted the db/fix-id-alias-assign-for-property-assignment branch January 24, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants