Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark identifier in System datasource as required #209

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Feb 28, 2024

Issues

Changelog

Update identifier field in System datasource from "Optional" (it isn't) to "Required"

  • List your changes here
  • Make a changie entry

Tophatting

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.71%. Comparing base (e3bdd4b) to head (baa4a20).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   44.71%   44.71%           
=======================================
  Files          71       71           
  Lines        5813     5813           
=======================================
  Hits         2599     2599           
  Misses       3209     3209           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidbloss davidbloss merged commit 78958fd into main Feb 28, 2024
5 checks passed
@davidbloss davidbloss deleted the db/update-system-data-source-field branch February 28, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants