Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add opslevel_integration_custom_event_check resource #498

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Oct 4, 2024

Resolves #158

🎗️ relies on terraform-opslevel-modules PR

Problem

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change

@davidbloss davidbloss requested a review from rocktavious October 4, 2024 21:00
}

cecIntegration, err := r.client.UpdateEventIntegration(input)
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the new opslevel api error stuff here if its not found?

Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to fix / improve

@davidbloss davidbloss merged commit 8cfb959 into main Oct 23, 2024
3 checks passed
@davidbloss davidbloss deleted the db/custom-and-deploy-integrations branch October 23, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plans to support creating Custom Event integrations?
2 participants