Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add opslevel_check_code_issue #523

Merged
merged 7 commits into from
Oct 24, 2024
Merged

add opslevel_check_code_issue #523

merged 7 commits into from
Oct 24, 2024

Conversation

davidbloss
Copy link
Contributor

Resolves #

Problem

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change

Comment on lines +67 to +72
stateModel.Filter = OptionalStringValue(string(check.Filter.Id))
stateModel.Id = ComputedStringValue(string(check.Id))
stateModel.Level = RequiredStringValue(string(check.Level.Id))
stateModel.Name = RequiredStringValue(check.Name)
stateModel.Notes = OptionalStringValue(check.Notes)
stateModel.Owner = OptionalStringValue(string(check.Owner.Team.Id))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we be federating this to NewCheckCodeBaseResourceModel ?

Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes and then maybe can we add 1 or 2 examples so they show up on the docs?

@davidbloss davidbloss marked this pull request as ready for review October 24, 2024 19:54
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 219 lines in your changes missing coverage. Please review.

Project coverage is 0.23%. Comparing base (ef57486) to head (5eed1ac).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
opslevel/resource_opslevel_check_code_issue.go 0.00% 196 Missing ⚠️
opslevel/resource_opslevel_check_base.go 0.00% 19 Missing ⚠️
...l/resource_opslevel_check_git_branch_protection.go 0.00% 3 Missing ⚠️
opslevel/provider.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #523      +/-   ##
========================================
- Coverage   0.23%   0.23%   -0.01%     
========================================
  Files         81      85       +4     
  Lines       9352    9547     +195     
========================================
  Hits          22      22              
- Misses      9327    9522     +195     
  Partials       3       3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidbloss davidbloss merged commit b25d4fc into main Oct 24, 2024
6 checks passed
@davidbloss davidbloss deleted the db/code-issue-check branch October 24, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants