-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add opslevel_check_code_issue #523
Conversation
stateModel.Filter = OptionalStringValue(string(check.Filter.Id)) | ||
stateModel.Id = ComputedStringValue(string(check.Id)) | ||
stateModel.Level = RequiredStringValue(string(check.Level.Id)) | ||
stateModel.Name = RequiredStringValue(check.Name) | ||
stateModel.Notes = OptionalStringValue(check.Notes) | ||
stateModel.Owner = OptionalStringValue(string(check.Owner.Team.Id)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we be federating this to NewCheckCodeBaseResourceModel
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes and then maybe can we add 1 or 2 examples so they show up on the docs?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
========================================
- Coverage 0.23% 0.23% -0.01%
========================================
Files 81 85 +4
Lines 9352 9547 +195
========================================
Hits 22 22
- Misses 9327 9522 +195
Partials 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #
Problem
Solution
Checklist