Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

note field on service_dependency correctly takes empty string #537

Merged
merged 2 commits into from
Nov 25, 2024
Merged

note field on service_dependency correctly takes empty string #537

merged 2 commits into from
Nov 25, 2024

Conversation

davidbloss
Copy link
Contributor

Resolves #

Problem

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change

@davidbloss davidbloss added the bug Something isn't working label Nov 21, 2024
@davidbloss davidbloss self-assigned this Nov 21, 2024
rocktavious
rocktavious approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Is there a way we can write a test for this?

@davidbloss davidbloss merged commit 751cf33 into main Nov 25, 2024
6 checks passed
@davidbloss davidbloss deleted the db/fix-svc-dep-note branch November 25, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocktavious rocktavious rocktavious approved these changes

Assignees

@davidbloss davidbloss

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbloss @rocktavious