Support direct signaling for advancing advertiser cleanroom state #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariiatuzovska
requested changes
Nov 27, 2024
juanli16
reviewed
Nov 27, 2024
Comment on lines
+274
to
+280
| func readersFromReadClosers(rs []io.ReadCloser) []io.Reader { | ||
| readers := make([]io.Reader, len(rs)) | ||
| for i, r := range rs { | ||
| readers[i] = r | ||
| } | ||
| return readers | ||
| } |
There was a problem hiding this comment.
It is actually still needed, we still perform matches, but not as a standalone command
There was a problem hiding this comment.
ah this was from the removed files
juanli16
approved these changes
Nov 28, 2024
mariiatuzovska
approved these changes
Nov 28, 2024
amanjpro
deleted the
support-direct-signaling-for-advancing-advertiser-cleanroom-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to directly ping the backend of the Optable DCN to advance the state of the PAIR advertiser.
That way they don't need to wait for the pubsub notification to ping the backend.
This will help with local testing and system testing