forked from larrychristensen/orcpub
-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #548 - fix subclass prof dropdowns #606
Closed
codeGlaze
wants to merge
16
commits into
Orcpub:develop
from
codeGlaze:548-fix-subclass-prof-dropdowns
Closed
Fixes #548 - fix subclass prof dropdowns #606
codeGlaze
wants to merge
16
commits into
Orcpub:develop
from
codeGlaze:548-fix-subclass-prof-dropdowns
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor + adds svg icons for rod-of-asclepius + changes CON icon to RoA + added some basic documentation to relevant functions
* Added dispatch to set default value * Changed range from 1:5 to 0:5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Properly sets the homebrew proficiency data and dropdown selection to a default number of
0
on page load. Preventing the mistake of people assuming they've selected1
from the menu. Prior to this1
was the default but was not set in memory until after selecting a different number.Related issue: fixes #548
Checklist: