Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #548 - fix subclass prof dropdowns #606

Closed

Conversation

codeGlaze
Copy link

Description:

Properly sets the homebrew proficiency data and dropdown selection to a default number of 0 on page load. Preventing the mistake of people assuming they've selected 1 from the menu. Prior to this 1 was the default but was not set in memory until after selecting a different number.

Related issue: fixes #548

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@codeGlaze codeGlaze closed this Mar 23, 2024
@codeGlaze codeGlaze deleted the 548-fix-subclass-prof-dropdowns branch March 23, 2024 04:04
@codeGlaze codeGlaze restored the 548-fix-subclass-prof-dropdowns branch March 23, 2024 04:07
@datdamnzotz datdamnzotz added this to the 2.5.0.25 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Dropdown Selection Don't Recognize '1' unless changed and changed back.
2 participants