This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The pull is mainly for review (not finished yet) as there are some things that I would like your opinion on.
These are the errors that still exist.
psql:qwat_to_epanet_views.sql:22: ERROR: relation "distribution.od_reservoir" does not exist
LINE 3: from distribution.OD_RESERVOIR;
^
psql:qwat_to_epanet_views.sql:74: ERROR: missing FROM-clause entry for table "p"
LINE 2: select v.id, p.fk_pipe_in as start_node, p.fk_pipe_out as en...
^
psql:qwat_to_epanet_views.sql:85: ERROR: column e.id does not exist
LINE 5: on e.id = n.id;
Thoughts regarding the valve view:
Basically, valves shouldn't exists at pipe ends in GIS. I believe having a pipe vertex where the valve touches the pipe is a good solution.
Do you think that we should use the underlying pipe start and end nodes and use it for the valve direction?
I am thinking of using the underlying pipe vertex and split the pipe in the view if the valve is closed etc.
Thoughts?