Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTC Talks 1 #10

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Update OTC Talks 1 #10

merged 9 commits into from
Feb 13, 2023

Conversation

tusharnankani
Copy link
Member

Looks like: /1

image

image

Home Page: /

image

@tusharnankani tusharnankani requested a review from a team January 15, 2023 07:38
Copy link
Member

@PranavDani PranavDani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check if where is needed.

1.html Show resolved Hide resolved
Copy link
Member

@HarshKapadia2 HarshKapadia2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, Tushar. The following are some of my thoughts and requested changes. LMK if something doesn't sit right with you.

1.html Outdated
Comment on lines 111 to 120
<h2>Supercharge your deployments with WASM</h2>
<p>
by
<a
href="https://twitter.com/rishit_dagli"
target="_blank"
rel="noreferrer"
>Rishit Dagli</a
>
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • How will we handle multiple talks in one OTC Talks session on this page? The page template should look like this is a one talk session and if required, another talk can be easily added. I know this is additional effort right now, but I think it will make automation easier later on if we have an extensible template ready to go.
  • I think we should have separate 'Title' and 'Speaker' sections per talk, in case we need to add more information about the speaker or something like that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • Something similar to this, where the summaries can be appended since the list will only get bigger.
  • Essentially breaking it into sections where the OTC Talk number with a link for that specific talk can be used.
  • This sounds similar to how we structure the summaries as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm okay. I will try to remodel it.

Copy link
Member Author

@tusharnankani tusharnankani Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

What do you think about this? Easy to automate, gives a good structure as well.

So, something like this:

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have an ordered list as well.

image

With some padding, we'll be good to go!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we please move the contact link to the 'When and Where' section and remove it from the 'Abstract'?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another idea is to rename the section 'When and Where' to 'Logistics'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When and Where easier to understand than logistics and we have used it in meetup repo as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the 'When and Where' section now has the rules, code of conduct and contact links as well, so renaming 'When and Where' to 'Logistics' makes more sense to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When and where and Logistics both sound off, went with something more generic.

Continue here: #10 (comment)

1.html Outdated Show resolved Hide resolved
1.html Show resolved Hide resolved
1.html Outdated Show resolved Hide resolved
1.html Outdated
Comment on lines 157 to 165
<p>
Feel free to
<a
href="https://links.ourtech.community"
target="_blank"
rel="noreferrer"
>contact us</a
>.
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this in the 'Relevant Links' section would be better in my opinion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant Links is with respect to the speaker and talk, that is why I would not prefer adding OTC Links (like COC, Rules, Contact Us) to Relevant Links.

index.html Outdated Show resolved Hide resolved
@tusharnankani
Copy link
Member Author

Looks like:

image

I think we can add a heading before listing the talks, and it might look neater.

@tusharnankani tusharnankani requested a review from a team January 26, 2023 09:01
@tusharnankani
Copy link
Member Author

Continued from #10 (comment)

image

image

How about now? @OurTechCommunity/core

@tusharnankani
Copy link
Member Author

tusharnankani commented Jan 28, 2023

and for a new section called 'Talk Index', 'Table of Contents' or something like that, which will have a <ul> for all the talks.

Just saw this, do you want an unordered list?

image

@tusharnankani
Copy link
Member Author

Another accessibility issue:

image

SRC: UI/UX Principle #46: Text Box Width Should Help Users Read

@tusharnankani
Copy link
Member Author

tusharnankani commented Jan 29, 2023

Let me know your preferences @OurTechCommunity/core

Let's merge this if it looks good and can be reused with the ideology of reusing a template and building remaining pages.

@HarshKapadia2
Copy link
Member

I understand the accessibility issue, but the more custom CSS we add, the more we're going to face issues with a common solution (OurTechCommunity/website#9), as more things will break and we'll have to modify more things. This is what is bugging me, that we're going to make things very difficult for ourselves for the future. One thing we can do is that we can note this accessibility issue in another issue and leave it be for now. Then again, I don't know when we're going to get to building the common solution, so maybe it is okay to implement it in this PR? What do others think?

Copy link
Member

@HarshKapadia2 HarshKapadia2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes that I could see. Let me know if I missed something or if something doesn't sit well with you. Thank you so much for the effort and sorry for keeping on pointing out issues!

1.html Outdated Show resolved Hide resolved
1.html Outdated Show resolved Hide resolved
1.html Outdated Show resolved Hide resolved
1.html Outdated Show resolved Hide resolved
@tusharnankani
Copy link
Member Author

Apologies for being dormant. On it!

@tusharnankani tusharnankani requested a review from a team February 13, 2023 16:57
@tusharnankani
Copy link
Member Author

Want to merge this, so we can update it with OTC Talks 2.

@HarshKapadia2 HarshKapadia2 merged commit 5e45186 into main Feb 13, 2023
@HarshKapadia2 HarshKapadia2 deleted the update-1 branch February 13, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants