-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OTC Talks 1 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check if where is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, Tushar. The following are some of my thoughts and requested changes. LMK if something doesn't sit right with you.
1.html
Outdated
<h2>Supercharge your deployments with WASM</h2> | ||
<p> | ||
by | ||
<a | ||
href="https://twitter.com/rishit_dagli" | ||
target="_blank" | ||
rel="noreferrer" | ||
>Rishit Dagli</a | ||
> | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- How will we handle multiple talks in one OTC Talks session on this page? The page template should look like this is a one talk session and if required, another talk can be easily added. I know this is additional effort right now, but I think it will make automation easier later on if we have an extensible template ready to go.
- I think we should have separate 'Title' and 'Speaker' sections per talk, in case we need to add more information about the speaker or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm okay. I will try to remodel it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can we please move the contact link to the 'When and Where' section and remove it from the 'Abstract'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another idea is to rename the section 'When and Where' to 'Logistics'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When and Where easier to understand than logistics and we have used it in meetup repo as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the 'When and Where' section now has the rules, code of conduct and contact links as well, so renaming 'When and Where' to 'Logistics' makes more sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When and where and Logistics both sound off, went with something more generic.
Continue here: #10 (comment)
1.html
Outdated
<p> | ||
Feel free to | ||
<a | ||
href="https://links.ourtech.community" | ||
target="_blank" | ||
rel="noreferrer" | ||
>contact us</a | ||
>. | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this in the 'Relevant Links' section would be better in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant Links is with respect to the speaker and talk, that is why I would not prefer adding OTC Links (like COC, Rules, Contact Us) to Relevant Links.
Co-authored-by: Harsh Kapadia <[email protected]>
Continued from #10 (comment) How about now? @OurTechCommunity/core |
Another accessibility issue: SRC: UI/UX Principle #46: Text Box Width Should Help Users Read |
Let me know your preferences @OurTechCommunity/core Let's merge this if it looks good and can be reused with the ideology of reusing a template and building remaining pages. |
I understand the accessibility issue, but the more custom CSS we add, the more we're going to face issues with a common solution (OurTechCommunity/website#9), as more things will break and we'll have to modify more things. This is what is bugging me, that we're going to make things very difficult for ourselves for the future. One thing we can do is that we can note this accessibility issue in another issue and leave it be for now. Then again, I don't know when we're going to get to building the common solution, so maybe it is okay to implement it in this PR? What do others think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes that I could see. Let me know if I missed something or if something doesn't sit well with you. Thank you so much for the effort and sorry for keeping on pointing out issues!
Apologies for being dormant. On it! |
Want to merge this, so we can update it with OTC Talks 2. |
Looks like:
/1
Home Page:
/