✨ Add Social Rules to CoC #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharnankani
approved these changes
Oct 14, 2022
|
Done @tusharnankani |
|
Bump @tusharnankani |
|
Looks good to me. Merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7.
(post-review) edit: Closes #11.
Adding social rules => Updating the Introduction and Attribution sections (a redundancy noted in #11), and actually adding the rules to the "Our Standards" section.
Two points to be noted:
My formatter went haywire, resulting in many changed lines. The contributing guidelines don't make it clear whether this is okay (see contributor guidelines may need to prescribe formatting rules as well #10). If necessary, I can amend the commit to undo this.
I had to choose between adding a concise version of the rules (like in https://kentcdodds.com/conduct), or the explanations as well (like in https://www.recurse.com/social-rules). For the moment, I've chosen to go with the former approach. As I see it, there are a few ways to do this:
a. Leave it as it is in the commit.
b. Add a line linking back to https://www.recurse.com/social-rules for further explanation.
c. Separate the social rules into another page entirely, seeing as they're not rules set in stone in the Code of Conduct.
d. Include the entire explanation of all four rules on the CoC page.
I don't recommend the last option, seeing as the page is already text-heavy. Regardless, I'll amend the commit based on reviews and suggestions.