Split doc #279
Split doc #279
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This is looking great! The docs are failing for an unrelated reason (lack of a UserAgent in our request calls). The fix needs to be determined first before we can build docs on RTD. Don't spend time on that. |
docs/notebooks/figanos_maps.ipynb
Outdated
| "\n", | ||
| "ens_stats = xr.open_dataset('../../datasets/hatchmap-ens_stats.nc').prcptot_mean\n", | ||
| "sup_8 = xr.open_dataset('../../datasets/hatchmap-sup_8.nc').changed\n", | ||
| "inf_5 = xr.open_dataset('../../datasets/hatchmap-inf_5.nc').changed\n", | ||
| "\n", |
There was a problem hiding this comment.
There will be a new functionality in xclim to better support fetching datasets from other repositories and caching them as needed.
Seeing as xclim is required to build the docs, I don't see the value in creating a testdata fetching mechanism specific to figanos.
There was a problem hiding this comment.
not sure I understand the comment ?
There is already a |
|
@Zeitsperre I added the test dat in data as we discussed. I will let you change the config for pooch. After that I just use fetch to access it ? |
|
@juliettelavoie Yes, exactly. I'll set things up so that the testing data is only fetched when running the notebooks and skipped on installation. Thanks again for your patience! |
|
maybe time to come back to the "if it ain't broke" method :P |
|
@juliettelavoie I wish there was an emoji for this:
|
| @@ -0,0 +1,493 @@ | |||
| { | |||
There was a problem hiding this comment.
On dirait le que le metadata "nbsphinx": "hidden" pour cacher cette cellule dans RtD a été enlevé
Reply via ReviewNB
| @@ -0,0 +1,493 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #45. # plt.savefig("images/station_map.png", bbox_inches='tight')
mais les images ne sont pas save dans images mais dans _static/_gallery, non ?
Reply via ReviewNB
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
New default projection
Other information:
plt.savefigbut I haven't been able to make it work.