Refactor Robot related code
#1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bulldozing a structure, the underlying terrain will already be `TerrainType::Dozed`. Hence there is no need to special case reading this terrain type. The general case will already store the expected value. By avoiding the special case, we can delay construction of the `Robot` until much later, where it is actually used.
It could only ever return `true`, and the result was never checked anywhere. Any errors were reported with exceptions.
It wouldn't make much sense to potentially complete processing and then call `mTaskCompleteSignal` after the `Robot` has self destructed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few simple miscellaneous changes to make future cleanup a little easier.
Some pre-work for:
RobotPoolencapsulation for command limit #1335