Updater: Fetch best asset size for download size notification #10090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenzek
reviewed
Oct 11, 2023
| @@ -393,7 +392,7 @@ void AutoUpdaterDialog::getChangesComplete(QNetworkReply* reply) | |||
| "that you will have to reconfigure your settings after this update.</p>")); | |||
| } | |||
| changes_html += tr("<h4>Installing this update will download %1 MB through your internet connection.</h4>") | |||
There was a problem hiding this comment.
If we want to be pedantic and change this to 1024 instead of 1000, should make this MiB, not MB.
There was a problem hiding this comment.
I changed it to 1024 to match GitHubs UI, which also reports it (incorrectly) as MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires my changes to our api to be deployed
Description of Changes
Retrieve the download size of our 'best' asset for the user and show that (extends #10068)
Rationale behind Changes
It'll fix #10087 once this and the "behind-the-scenes" change is deployed