SPU2: Optimize reverb resampling #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziemas
force-pushed
the
spu-reverb-investigation
branch
2 times, most recently
from
b558523 to
76fd2c5
Compare
|
Using GSVector seems out of place currently since it's for GS only. What we could do is move it to common and rename it to Vector only or something like that. That way it can be used anywhere. |
|
FYI, The AVX2 paths will have no effect in the CI/Releases builds, unless you do the whole function-pointer+Multi-ISA thing. As for the name, eh, I'm so used to using GSVector that I think renaming it would actually be a detriment. |
|
Going to try to set up the multi-isa thing. |
Ziemas
force-pushed
the
spu-reverb-investigation
branch
from
40aa352 to
c853d9d
Compare
Ziemas
force-pushed
the
spu-reverb-investigation
branch
3 times, most recently
from
bfac162 to
fa4501a
Compare
kamfretoz
approved these changes
Oct 18, 2023
Ziemas
force-pushed
the
spu-reverb-investigation
branch
from
fa4501a to
bcdabde
Compare
Ziemas
force-pushed
the
spu-reverb-investigation
branch
from
bcdabde to
0b35a98
Compare
kamfretoz
approved these changes
Oct 19, 2023
Mrlinkwii
approved these changes
Oct 19, 2023
JordanTheToaster
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Use SIMD for resampling.
Rationale behind Changes
Vroom vroom.
Suggested Testing Steps
Check that things sound the same.
Ok so this is probably a marginal improvement TBH. But I was bored enough to muck around with it. I'll use this opportunity to see what you guys think about using GSVector in the SPU :^)