EE: Correct update of EE cycles on low cycle counts when overclocking #11197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrlinkwii
approved these changes
May 9, 2024
kamfretoz
approved these changes
May 9, 2024
JordanTheToaster
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Corrects cycle masking when a block has a low cycle count while overclocking.
Rationale behind Changes
The mask to retain fractional values was different to what was actually being used when the cycle count was low, causing the cycle count to be wrong. This regressed Panzer Elite Action - Fields of Glory
I also removed the hack from MFC0 where it was fudging adding a cycle to the COP0 counter, this was wrong.
Suggested Testing Steps
Try Panzer Elite Action - Fields of Glory, and any other games which use overclocking in the gamedb, don't care too much about others.
Fixes #4793