GS/HW: Adjust conditions for CPU sprite renderer #11260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
gs_csbwlvl3
branch
from
caa0a13 to
fb107b9
Compare
refractionpcsx2
force-pushed
the
gs_csbwlvl3
branch
from
fb107b9 to
c385cfa
Compare
refractionpcsx2
changed the title
JordanTheToaster
approved these changes
May 17, 2024
kamfretoz
approved these changes
May 17, 2024
TheTechnician27
approved these changes
May 18, 2024
There was a problem hiding this comment.
Tested on Jak X, and it looks good there, fixing the coloration of the vehicles which was previously broken (I also noticed that in order to fully work, the reflective surfaces of the vehicles need high blending). Any particular part of Jak 3 you think should be tested, meanwhile?
Somewhere watery or with lots of visible (night?) sky are good, and the intro :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adjusts the conditions for CPU sprite renderer triggering.
Rationale behind Changes
Some games like Spider-Man 3 and Driv3r require a high level of software drawing to fix some issues, but break other things as a result as they need the information in the render target, however these draws don't really the software renderer to be successful.
Suggested Testing Steps
Test Driv3r and Spider-Man 3, Wall-E, Jak 3, Jak-X Combat Racing and some random stuff.
Jak and Daxter - The Lost Frontier's upscaled shadow that was fudged with the software sprite renderer is no longer fixed by it, it's a casualty, but what can you do.
Driv3r:
Master:
PR:
Spider-Man 3 (with the higher sprite level required for some upcoming changes in #11241 ):
Master:
PR:
Jak-X Combat Racing:
Master:
PR:
Wall-E:
Master:
PR: