Misc: Minor text and settings changes #11751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlDucci
reviewed
Aug 26, 2024
| <property name="text"> | ||
| <string>Skip Presenting Duplicate Frames</string> | ||
| <string>Disable Mailbox Presentation</string> |
There was a problem hiding this comment.
Could we use this PR to also add a comment for translators? Here's an example:
<string extracomment="Mailbox Presentation: a type of graphics-rendering technique that has not been exposted to the public that often, so chances are you will need to keep the word \"mailbox\" in English. It does not have anything to do with postal mailboxes or email inboxes/outboxes.">Disable Mailbox Presentation</string>
There was a problem hiding this comment.
Hopefully this is correct if you can confirm.
There was a problem hiding this comment.
Make sure the quotation marks of "mailbox" are properly escaped.
Besides that, LGTM, though if anyone can properly summarize how does this feature work, we translators would appreciate it.
JordanTheToaster
force-pushed
the
test
branch
4 times, most recently
from
c8cc329 to
a59454e
Compare
kamfretoz
reviewed
Aug 27, 2024
kamfretoz
approved these changes
Aug 27, 2024
F0bes
reviewed
Aug 28, 2024
F0bes
approved these changes
Aug 28, 2024
SternXD
pushed a commit
to EmulationCollective/XBSX2
that referenced
this pull request
Oct 16, 2024
* VMManager: Update CPU detection text * Settings: Move texture preload to advanced * Settings: Move spin during readback to advanced * Translations: Add extra comment to mailbox presentation Update GraphicsSettingsWidget.ui
RedPanda4552
pushed a commit
to RedPanda4552/pcsx2
that referenced
this pull request
Dec 20, 2024
* VMManager: Update CPU detection text * Settings: Move texture preload to advanced * Settings: Move spin during readback to advanced * Translations: Add extra comment to mailbox presentation Update GraphicsSettingsWidget.ui
SternXD
pushed a commit
to EmulationCollective/XBSX2
that referenced
this pull request
Dec 22, 2024
* VMManager: Update CPU detection text * Settings: Move texture preload to advanced * Settings: Move spin during readback to advanced * Translations: Add extra comment to mailbox presentation Update GraphicsSettingsWidget.ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Changes to CPU detection and feature detection text as well as moving texture preloading into advanced settings.
Rationale behind Changes
More text more gooder.
Suggested Testing Steps
Make sure the things work and that texture preloading setting still works already checked this one but will be good to double check.