Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Add all levels/unclamped mipmap modes,credit by stenzek #11787

Closed
wants to merge 2 commits into from

Conversation

crashGG
Copy link
Contributor

@crashGG crashGG commented Sep 8, 2024

Description of Changes

This PR brings back the mipmapping dropdown (oh noes), but it does not bring back basic (phew).

It adds two new modes:

All Levels
Instead of creating TC sources with LODs M..MXL, where M is the highest LOD from the vertex trace, it always uploads mip levels 0..MXL. This should have the result of producing fewer duplicate textures when dumping, and potentially increase TC efficiency, since there's less duplicates in the hash cache too.

Unclamped
This is a new, enhanced mode, that uses the full range of texture LODs that the game provides, but ignores the L/K values/game's bias. This results in higher-resolution textures being used when upscaling, and makes anisotropic filtering work again without requiring forced trilinear.

Rationale behind Changes
New enhancement for improved visuals in games, because forcing mipmapping everywhere was actually a visual regression in some cases.

credit by stenzek

Suggested Testing Steps

Burnout 3, Need for speed 6 ,and other racing games with super long viewing distance

@PCSX2 PCSX2 locked and limited conversation to collaborators Sep 8, 2024
@GovanifY GovanifY closed this Sep 8, 2024
@PCSX2 PCSX2 unlocked this conversation Sep 8, 2024
@F0bes
Copy link
Member

F0bes commented Sep 8, 2024

Do you have permission by Stenzek to take his previous work and open a pr for it?

@crashGG
Copy link
Contributor Author

crashGG commented Sep 8, 2024

1.This code complies with the GPL-3.0 license.
2.I do not have the authorship of this code, I have stated that the authorship belongs to Stenzek.
3.Once a code is created, it is like a digital life. Unless it violates the law or license, it should not be deprived of its freedom.
4.Our common goal is to make pcsx2 better. If you don't like it, you can reject this PR. We can also understand you and not make similar PRs.

@F0bes
Copy link
Member

F0bes commented Sep 8, 2024

I'd rather try be on good terms with notable people than sit in a circle and yell about the GPL. It's better to make friends than enemies.

To add on: Stenzek has been clear he did not want his code reused and I would rather avoid any issues related to that.

@PCSX2 PCSX2 locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants