Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: update Mipmapping description #11806

Closed
wants to merge 1 commit into from

Conversation

OctopusButtons
Copy link
Contributor

Added mipmapping description similar to the Help/hover text of other items. Old version only said that it's required for some games. Wording is my own phrasing.

In keeping with the brief informative explanations of other items in the Help/hover text. Previously it only said that it's required for some games to render correctly.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@F0bes
Copy link
Member

F0bes commented Sep 12, 2024

The change is fine. Can you prefix the commit though? Something like UI: Update mipmapping help description would do.

@OctopusButtons
Copy link
Contributor Author

Oops I'm sorry, I labelled the PR but forgot about the original commit name. (I read the guidelines and also looked at merges to see what headers people were using, mistakenly only thinking my PR.) Looks like the web version doesn't let me change the name afterward, so I will close this PR and re-do. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants