-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Soft-Float] - Initial Interpreter Implementation of Ps2's floating point unit specification #12001
Open
GitHubProUser67
wants to merge
12
commits into
PCSX2:master
Choose a base branch
from
GitHubProUser67:soft-float-int
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,224
−734
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
de047ea
[Soft-Float] - Initial Interpreter Implementation of Ps2's floating p…
GitHubProUser67 b7f3806
[Soft-Float] - Fixes Tony Hawk Pro Skater 4 Mul issue.
GitHubProUser67 b09bfb0
[FPU] - Uses Soft-Float comparison.
GitHubProUser67 3bd88f7
[VUops] - Implements accurate SQRT/RSQRT + removal of TriAce hack.
GitHubProUser67 3fe4277
[Soft-Float] - Fixes Operand checking for denormals Add/Sub operations.
GitHubProUser67 d5e5028
[Soft-Float] - Removes "special" COP1 mode.
GitHubProUser67 98e3df3
[Soft-Float] - Implements fully accurate Mul operations.
GitHubProUser67 34753ae
Arrange code style to accommodate requested changes.
GitHubProUser67 b0b65fa
[Soft-Float] - Removes Div "special" normalization constant.
GitHubProUser67 8bc2ed9
[Soft-Float] - Code review Part1.
GitHubProUser67 745e474
[Soft-Float] - Improves the PS2Float class by using a raw float to sp…
GitHubProUser67 5b94f53
[Soft-Float] - Fixes MAC-OS compile error + moves the bitUtils method…
GitHubProUser67 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you can drop the rest of the changes and make BitScanReverse8 and clz just call this (or pick one and stop using the rest).
As a side note, not handling the value == 0 case will be a bit cheaper, and in my experience in pretty much all cases, the caller has already checked and is only calling this if they know
value
is nonzero, so the separate check here is just wasted cycles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will do that when possible and push, I admit I lacked experience with the BitScan part.