Console: Limit buffer size in ConsoleLogFromVM::Write #12034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The buffer size for lines written to the EE/IOP consoles has been limited to 4096 characters. In addition, consecutive newline characters are no longer eaten.
Rationale behind Changes
Previously it was very easy to accidentally exhaust the host's memory. For example, if you made an infinite loop and forgot the newline character. Since there would be no output it wouldn't be immediately obvious what was wrong either.
Here's a small program that triggers this behaviour:
Suggested Testing Steps
Here's the above program in its compiled form:
exhaustmem.zip
Since it's been intentionally written to use up lots of memory think twice before running it.
Note that the Qt console window has a similar quirk where it will just keep using more and more memory. This PR doesn't address that issue.