Savestate: Always write HostFS savestate tag (Savestate bump) #12041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add bounds checking for
FreezeMemloadsAlways save HostFS data
Rationale behind Changes
When a savestate is saved without Host File System enabled, this tag is omitted.
If that savestate is then loaded after enabling Host File System, then FreezeTag will fail to find HostFS tag and reject the savestate
Additionally,
FreezeTagwill end up reading beyond the end of the savestate in such a situation.Suggested Testing Steps
Test savestates with and without Host filesystem enabled.