EE Cache: Writeback dirty cache entries when exiting the interpreter. #12069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F0bes
force-pushed
the
int-exit-cache-writeback
branch
from
f3df9b6 to
c94c9be
Compare
TheLastRar
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Bionicle Heroes (I listed the wrong game in Discord) no longer (inconsistently) crashes the emulator on the language select screen when you enable recompiler.
Bionicle (the not Heroes one) no longer crashes if you enable the recompiler just before the intro FMV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Introducing another fix that affects 0.01% of users. 🥳
When the interpreter shuts down and control goes to the recompiler I've made it so all EE cache entries are written back to memory.
Rationale behind Changes
This fixes #6637
Suggested Testing Steps
Run a game, enable the EE cache, disable the recompiler, and then enable the recompiler. It some instances it would cause PCSX2 to crash or the game to TLB miss and freeze. This should have been addressed in this PR.