ChdFileReader: implement precaching of CHD files within PCSX2 instead of modifying libchdr #12086
+151
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CDVD
Dependencies
TheLastRar
force-pushed
the
chd-core-precache
branch
from
16b3cf8 to
121ffea
Compare
TheLastRar
changed the title
|
I know it's not ready for review, but I was curious and ran it through a profiler and verified that there is no significant performance decrease or increase. We are still fread() bound. |
TheLastRar
force-pushed
the
chd-core-precache
branch
from
121ffea to
14d7e70
Compare
JordanTheToaster
approved these changes
Dec 16, 2024
kamfretoz
approved these changes
Dec 16, 2024
TheLastRar
force-pushed
the
chd-core-precache
branch
from
14d7e70 to
941f7b2
Compare
TheLastRar
force-pushed
the
chd-core-precache
branch
from
941f7b2 to
8e545f9
Compare
TheLastRar
force-pushed
the
chd-core-precache
branch
from
8e545f9 to
0ea3404
Compare
|
Marking this as ready. I'm not yet 100% sure on |
TheLastRar
force-pushed
the
chd-core-precache
branch
from
0ea3404 to
565407e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removes the patches applied to libchdr, and instead uses libchdr's virtual IO API to achieve the same behaviour.
Rationale behind Changes
Such patches can be missed when updating dependencies, potentially leading to difficulty updating.
We now also precache parent CHD files, which the patched libchdr did not.
Includes on #12075
Suggested Testing Steps
Test precaching using CHD files